Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix process is not defined in react-native #526

Merged
merged 1 commit into from
Aug 15, 2015

Conversation

chentsulin
Copy link
Contributor

process doesn't exist in react-native's JavaScriptCore environment, so we should do something like react-redux connect does now.

https://github.com/gaearon/react-redux/blob/master/src/components/createConnect.js#L192

@chentsulin
Copy link
Contributor Author

#525

gaearon added a commit that referenced this pull request Aug 15, 2015
fix `process is not defined` in react-native
@gaearon gaearon merged commit 7d2ef9e into reduxjs:master Aug 15, 2015
@gaearon
Copy link
Contributor

gaearon commented Aug 15, 2015

Thanks a lot! Out in 1.0.1.

@vincentfretin
Copy link
Contributor

Just for reference, I guess it's fixed in react-native too:
https://github.com/facebook/react-native/releases/tag/v0.10.0-rc lists the following:
process.env.NODE_ENV: This value is defined to be "production" or "development" based on your current environment. Now you can use npm packages that rely on NODE_ENV!

@grabbou
Copy link

grabbou commented Nov 17, 2015

Yep, I think this can be simplified now back to the NODE_ENV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants