Skip to content

Commit

Permalink
fix(deps) Temporary fix for broken @swc/types package publishing (#10690
Browse files Browse the repository at this point in the history
)
  • Loading branch information
Tobbe committed May 28, 2024
1 parent f1eb271 commit ab39076
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .changesets/10690.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
- fix(deps) Temporary fix for broken @swc/types package publishing (#10690) by @Tobbe

Set yarn package resolutions to get a working version of @swc/types as
recommended by the Storybook team (see link below)

Ideally we can get rid of this very soon. Resolutions are a pain to deal with
in user's projects because we have to tell them to manually get rid of them
when they're not needed anymore.

See https://github.com/swc-project/swc/issues/8988
and https://github.com/storybookjs/storybook/issues/27385
5 changes: 4 additions & 1 deletion __fixtures__/fragment-test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,8 @@
"prisma": {
"seed": "yarn rw exec seed"
},
"packageManager": "[email protected]"
"packageManager": "[email protected]",
"resolutions": {
"@swc/core": "1.5.7"
}
}
1 change: 1 addition & 0 deletions __fixtures__/test-project-rsa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"resolutions": {
"@apollo/client-react-streaming/superjson": "^1.12.2",
"@apollo/client/rehackt": "0.1.0",
"@swc/core": "1.5.7",
"react-is": "19.0.0-beta-04b058868c-20240508"
}
}
1 change: 1 addition & 0 deletions __fixtures__/test-project-rsc-kitchen-sink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"resolutions": {
"@apollo/client-react-streaming/superjson": "^1.12.2",
"@apollo/client/rehackt": "0.1.0",
"@swc/core": "1.5.7",
"react-is": "19.0.0-beta-04b058868c-20240508"
}
}
1 change: 1 addition & 0 deletions __fixtures__/test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"resolutions": {
"@storybook/react-dom-shim@npm:7.6.17": "https://verdaccio.tobbe.dev/@storybook/react-dom-shim/-/react-dom-shim-8.0.8.tgz",
"@apollo/client/rehackt": "0.1.0",
"@swc/core": "1.5.7",
"react-is": "19.0.0-beta-04b058868c-20240508"
}
}
1 change: 1 addition & 0 deletions packages/create-redwood-app/templates/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"resolutions": {
"@storybook/react-dom-shim@npm:7.6.17": "https://verdaccio.tobbe.dev/@storybook/react-dom-shim/-/react-dom-shim-8.0.8.tgz",
"@apollo/client/rehackt": "0.1.0",
"@swc/core": "1.5.7",
"react-is": "19.0.0-beta-04b058868c-20240508"
}
}
1 change: 1 addition & 0 deletions packages/create-redwood-app/templates/ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"resolutions": {
"@storybook/react-dom-shim@npm:7.6.17": "https://verdaccio.tobbe.dev/@storybook/react-dom-shim/-/react-dom-shim-8.0.8.tgz",
"@apollo/client/rehackt": "0.1.0",
"@swc/core": "1.5.7",
"react-is": "19.0.0-beta-04b058868c-20240508"
}
}

0 comments on commit ab39076

Please sign in to comment.