Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack v4 to v5 #1667

Closed
peterp opened this issue Jan 24, 2021 · 5 comments · Fixed by #2884
Closed

Upgrade webpack v4 to v5 #1667

peterp opened this issue Jan 24, 2021 · 5 comments · Fixed by #2884
Assignees
@thedavidprice
Labels
release:breaking This PR is a breaking change topic/config Babel, Webpack, ESLint, Prettier, etc.

Comments

@peterp
Copy link
Contributor

peterp commented Jan 24, 2021

Previously we were blocked by the fact that Storybook was on Webpack 4, but they've already upgraded to Webpack 5.

Here are the docs for upgrading: https://webpack.js.org/migrate/5/
@peterp
Copy link
Contributor Author

peterp commented Jan 24, 2021

It looks like Storybook does not support Webpack 5: storybookjs/storybook#13392 :/

@Tobbe
Copy link
Member

Tobbe commented Jan 25, 2021

We use chalk a lot. Would this be an issue for us as well? facebook/create-react-app#10198

@Tobbe
Copy link
Member

Tobbe commented Feb 5, 2021

Storybook Wp5 support:
image

@thedavidprice thedavidprice mentioned this issue Mar 17, 2021
Merged
3 tasks
@thedavidprice
Copy link
Contributor

Now that we've upgraded to Storybook v6, which is using Webpack v5, when should we prioritize upgrading to Webpack v5 @peterp?

@dthyresson
Copy link
Contributor

@jtoar Will an upgrade to Webpack v5 be needed if upgrading to PostCss 8? See: #2123

@dthyresson dthyresson added the topic/config Babel, Webpack, ESLint, Prettier, etc. label Mar 26, 2021
@jtoar jtoar linked a pull request May 18, 2021 that will close this issue
Upgrade webpack v5 and related modules #2402
Closed
5 tasks
@jtoar jtoar added the release:breaking This PR is a breaking change label May 18, 2021
@jtoar jtoar added this to the v1.0 milestone May 18, 2021
@jtoar jtoar modified the milestones: v1.0, next-release-candidate May 19, 2021
@jtoar jtoar removed this from the next-release-candidate milestone Jun 4, 2021
@jtoar jtoar closed this as completed Jul 18, 2021
@jtoar jtoar linked a pull request Jul 18, 2021 that will close this issue
Webpack v5; Use PostCSS v8 with Tailwind Setup #2884
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedavidprice thedavidprice

Labels
release:breaking This PR is a breaking change topic/config Babel, Webpack, ESLint, Prettier, etc.
Projects
None yet
Milestone
No milestone
5 participants
@thedavidprice @Tobbe @peterp @dthyresson @jtoar