Add a11y configuration for eslint and storybook

[jtoar]

This PR follows up on the discussion around #1793, adding eslint and and storybook a11y tooling at the framework level that can be turned off with a toml var (all of it's on by default).

• what should the name of the toml var be?
  • enableA11yTooling, a11yTooling... just a11y?
    • if we end up adding skip links at the framework level, it might even make sense to add a table, [a11y], and then list all the vars there with more descriptive names
• actually test this stuff once I get the hang of the new contributing workflow (and maybe PR a fix for symlinking packages/core)
  • some of the jsx-a11y rules might need to be turned off, just not sure which ones yet
• revert prisma being added to packages/core it was just moved, not added; it's consistent with what's in main

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/create-redwood-app-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-api-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-api-server-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-auth-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-cli-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-core-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-dev-server-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-eslint-config-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-eslint-plugin-redwood-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-forms-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-internal-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-prerender-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-router-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-structure-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-testing-0.27.1-487c6ab.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1849/redwoodjs-web-0.27.1-487c6ab.tgz

Install this PR by running yarn rw upgrade --pr 1849:0.27.1-487c6ab

[jtoar]

@peterp turns out eslint-plugin-jsx-a11y has been in the framework since PR #6—it just wasn't enabled!

[jtoar]

Picked this up again today; the storybook command still works (and the add on too), but there's this long error message about something being broken in axe-core: https://s.tape.sh/bCLk58nV

[jtoar]

Looks like we can resolve this error by upgrading to storybook 6 (see storybookjs/storybook#14160). We're on:

redwood/packages/core/package.json

Line 27 in 49a55e6

"@storybook/react": "^5.3.19",

Dependabot recently tried to get us to upgrade; the CI passed: #1926.

[jtoar]

If this gets merged, it would render the work here (integrating the a11y addon) moot: storybookjs/storybook#12485. Not sure when or if it will though, so it's still worth doing this.

[thedavidprice]

We need to upgrade Storybook to v6 for this. Dependabot tried to and it passed our CI: #1926

^^ @jtoar there are more steps to this than upgrading the package. This is on @peterp's radar — perhaps you should connect with him and bump priority.

Also related to #1667 (Storybook has since upgraded to Webpack v5)

[cypress]

---

Test summary

11 • 0 • 1 • 0 • 0

---

Run details

Project	RedwoodJS Framework
Status	Passed
Commit	8176c93 ℹ️
Started	Mar 23, 2021 4:03 PM
Ended	Mar 23, 2021 4:06 PM
Duration	02:48 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 89

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[peterp]

Nice! Reviewing this now!

[thedavidprice]

@jtoar surprise! Storybook now upgraded to v6 as of #2054 🚀