feat(cli): Add experimental setup command for React Compiler #10574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the eslint plugin will not work until this fix has been published out to npm: facebook/react#29072. Update: this fix has now been published and the setup command works as expected. |
Josh-Walker-GM
added a commit
that referenced
this pull request
May 17, 2024
**Problem** The react compiler has been discussed at the react conference and we should make it as easy as possible for people to try out in redwood. Especially since if you visit https://react.dev/learn/react-compiler you'll see specific mention of nextjs, remix and expo but not redwoodjs. **Changes** 1. Adds an experiment setup command which will add a flag to the `redwood.toml`, and install the react compiler eslint and babel plugin packages. 2. Conditionally adds the eslint plugin & rule to our eslint config based on the toml flag 3. Conditionally adds the babel plugin to our vite build process based on the toml flag. **Testing** I have only tested this on our standard test project fixture where you can see the compiler in action when you look via the react dev tools: <img width="1468" alt="Screenshot 2024-05-15 at 21 42 11" src="https://github.com/redwoodjs/redwood/assets/56300765/e5113d1c-ba9f-48ca-9e4b-d0243758050a">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The react compiler has been discussed at the react conference and we should make it as easy as possible for people to try out in redwood. Especially since if you visit https://react.dev/learn/react-compiler you'll see specific mention of nextjs, remix and expo but not redwoodjs.
Changes
redwood.toml, and install the react compiler eslint and babel plugin packages.Testing
I have only tested this on our standard test project fixture where you can see the compiler in action when you look via the react dev tools:
Notes