fix(graphql): Allow including 'File' scalar by default to be disabled #11540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
reviewed
Sep 13, 2024
| db.$disconnect() | ||
| }, | ||
| // highlight-start | ||
| includeScalars: { |
There was a problem hiding this comment.
This is better than what I had - the config is at least consistent looking between toml and Yoga config. Nice.
dthyresson
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Thanks for this! @Josh-Walker-GM
LGTM and will now let people who have had a Prisma File model opt out effectively of Uploads.
My only question is if in The Default Scalars docs or in Storage we should mention that if you opt out of the file scalar, your project will not be able to use Redwood Storage or any GraphQL file upload.
Tobbe
previously requested changes
Sep 13, 2024
|
Love that this is still enabled by default and it's opt out! |
|
We decided we wanted to go ahead with this as a fix for the reported problem. |
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 19, 2024
…#11540) There was a problem introduced in v8 when we included the `File` scalar by default. This meant a custom implementation by the user could be clobbered by the new default. This change allows the user to supply config to disable including it by default. This is not how I would have loved to have done things here. Config in two places is rubbish but given the organisation of this currently it was generally unavoidable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem introduced in v8 when we included the
Filescalar by default. This meant a custom implementation by the user could be clobbered by the new default. This change allows the user to supply config to disable including it by default.This is not how I would have loved to have done things here. Config in two places is rubbish but given the organisation of this currently it was generally unavoidable.