Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade nhost to 1.4.10 #6646

Closed
wants to merge 1 commit into from
Closed

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Oct 11, 2022

v1.5.0 was causing issues with my decouple auth PR

src/nhost/nhost.ts(6,17): error TS2742: The inferred type of 'createNhostAuth' cannot be named without a reference to '@nhost/nhost-js/node_modules/@nhost/core'. This is likely not portable. A type annotation is necessary.

Doing this change made the error go away

image

So I tried to downgrade to the previous version of nhost (1.4.10), and the original code started working again.

There's also this TS issue that might be related
microsoft/TypeScript#48212

But for now I think we should just downgrade, then we can worry about upgrading when nhost lives in its own auth package

@Tobbe Tobbe enabled auto-merge (squash) October 11, 2022 00:15
@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Oct 11, 2022
@jtoar
Copy link
Contributor

jtoar commented Oct 11, 2022

I'll include this in #6647.

@jtoar jtoar closed this Oct 11, 2022
auto-merge was automatically disabled October 11, 2022 00:37

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants