Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(streaming-ssr): Fixes running the streaming server using rw serve #9558

Merged
merged 6 commits into from
Nov 27, 2023
Merged

fix(streaming-ssr): Fixes running the streaming server using rw serve #9558

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5788158
fix(streaming-ssr): Fixes running the streaming server using rw serve…
dac09 Nov 20, 2023
676e8f4
Merge branch 'main' into fix/webserver-windows-import
dac09 Nov 21, 2023
e4c8d4e
Merge branch 'main' into fix/webserver-windows-import
dac09 Nov 21, 2023
b28beb7
Merge branch 'main' into fix/webserver-windows-import
dac09 Nov 22, 2023
2d07396
Merge branch 'main' into fix/webserver-windows-import
dac09 Nov 27, 2023
dd5e4fa
Merge branch 'main' into fix/webserver-windows-import
dac09 Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/vite/src/streaming/createReactStreamingHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ export const createReactStreamingHandler = async (
let fallbackDocumentImport: any

if (isProd) {
entryServerImport = await import(rwPaths.web.distEntryServer)
fallbackDocumentImport = await import(rwPaths.web.distDocumentServer)
entryServerImport = await import(makeFilePath(rwPaths.web.distEntryServer))
fallbackDocumentImport = await import(
makeFilePath(rwPaths.web.distDocumentServer)
)
}

// @NOTE: we are returning a FetchAPI handler
Expand Down Expand Up @@ -134,3 +136,8 @@ export const createReactStreamingHandler = async (
return reactResponse
}
}

function makeFilePath(path: string): string {
// Without this, absolute paths can't be imported on Windows
return 'file:///' + path
}
Loading