Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crwa): clarify docs to avoid issues in yarn modern installs #9579

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Nov 27, 2023

Fix for #9578 and https://community.redwoodjs.com/t/yarn-redwood-dev-throwing-internal-error/5557. @Tobbe and I paired on this one. Basically, there's a footgun in the yarn docs. If you read them too quickly, it seems like you can update your global version of yarn via yarn set version stable. But that command is actually only meant to be used in the context of a project (like a Redwood app).

@jtoar jtoar added topic/crwa create-redwood-app release:fix This PR is a fix labels Nov 27, 2023
@jtoar jtoar added this to the next-release-patch milestone Nov 27, 2023
@jtoar jtoar force-pushed the ds-crwa/handle-yarn-stable-and-corepack branch from dca5e1f to 611cc14 Compare November 28, 2023 17:28
@jtoar jtoar marked this pull request as ready for review November 28, 2023 17:28
@jtoar jtoar added release:docs This PR only updates docs and removed release:fix This PR is a fix labels Nov 28, 2023
@jtoar jtoar changed the title fix(crwa): smooth issues in yarn modern installs fix(crwa): clarify docs to avoid issues in yarn modern installs Nov 28, 2023
@jtoar jtoar merged commit 6a6c4a8 into main Nov 28, 2023
32 of 33 checks passed
@jtoar jtoar deleted the ds-crwa/handle-yarn-stable-and-corepack branch November 28, 2023 17:39
jtoar added a commit that referenced this pull request Nov 29, 2023
Fix for #9578 and
https://community.redwoodjs.com/t/yarn-redwood-dev-throwing-internal-error/5557.
@Tobbe and I paired on this one. Basically, there's a footgun in the
yarn docs. If you read them too quickly, it seems like you can update
your global version of yarn via `yarn set version stable`. But that
command is actually only meant to be used in the context of a project
(like a Redwood app).
dac09 added a commit to dac09/redwood that referenced this pull request Dec 1, 2023
…ath-aliases

* 'main' of github.com:redwoodjs/redwood: (23 commits)
  Add note about base 64 encoded event body (redwoodjs#9595)
  fix(deps): update graphql-tools monorepo (redwoodjs#9609)
  fix(deps): update dependency fs-extra to v11.2.0 (redwoodjs#9606)
  fix(deps): update dependency graphql-sse to v2.4.0 (redwoodjs#9607)
  fix(deps): update docusaurus monorepo to v3.0.1 (redwoodjs#9608)
  fix(deps): update babel monorepo (redwoodjs#9596)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (redwoodjs#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (redwoodjs#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (redwoodjs#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (redwoodjs#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (redwoodjs#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (redwoodjs#9598)
  fix(deps): update storybook monorepo to v7.6.2 (redwoodjs#9597)
  RSC: Generate a route manifest (redwoodjs#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (redwoodjs#9575)
  add documentation on mocking useParams in component test (redwoodjs#9284)
  Update Typescript to 5.3.2 (redwoodjs#9589)
  RSC: Refactor build process (redwoodjs#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (redwoodjs#9579)
  ...
@Tobbe Tobbe modified the milestones: next-release, v6.5.0 Dec 1, 2023
dac09 added a commit that referenced this pull request Jan 22, 2024
…nario-multiple-tests

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (#9598)
  fix(deps): update storybook monorepo to v7.6.2 (#9597)
  RSC: Generate a route manifest (#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (#9575)
  add documentation on mocking useParams in component test (#9284)
  Update Typescript to 5.3.2 (#9589)
  RSC: Refactor build process (#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (#9579)
  fix: Prevent `rw graphiql setup` from breaking with encryptSession error (#9582)
  fix: Remove "god code" typos from auth READMEs (#9583)
  Experimental Dockerfile: Fix typo in setup command (#9577)
  fix(streaming-ssr): Fixes running the streaming server using rw serve (#9558)
  9316/update mantine setup (#9388)
  chore: clean up `RouteParams` type test structure (#9573)
  ...
jtoar pushed a commit that referenced this pull request Feb 3, 2024
#9579 also applies here, took
like an hour to get a `yarn build` to succeed because a build was very
close to working but didn't
jtoar pushed a commit that referenced this pull request Feb 4, 2024
#9579 also applies here, took
like an hour to get a `yarn build` to succeed because a build was very
close to working but didn't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs topic/crwa create-redwood-app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants