Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix soundness bug in NotNan::cmp. #151

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Fix soundness bug in NotNan::cmp. #151

merged 1 commit into from
Jun 29, 2024

Commits on Jun 29, 2024

  1. Fix soundness bug in NotNan::partial_cmp. 

    Ill-behaved FloatCore implementations for user types could have
`x.partial_cmp(&x) == None` even when `x.is_nan() == false`.  This crate
will now panic in those cases, rather than execute undefined behavior.

Fixes #150.
    @mbrubeck
    mbrubeck committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2f67d25 View commit details
    Browse the repository at this point in the history