test: ignore spurious 'EMFILE'

According to the explanation in nodejs#3635#issuecomment-157714683 And as a continuation to nodejs#5422 we also ignore EMFILE "No more file descriptors are available,so no more files can be opened" PR-URL: nodejs#12698 Fixes: nodejs#10286 Refs: nodejs#3635 (comment) Refs: nodejs#5178 Refs: nodejs#5179 Refs: nodejs#4005 Refs: nodejs#5121 Refs: nodejs#5422 Refs: nodejs#12621 (comment) Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
refack · May 19, 2017 · 6f21671 · 6f21671
1 parent 51664fc
commit 6f21671
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/test/parallel/test-child-process-fork-regr-gh-2847.js b/test/parallel/test-child-process-fork-regr-gh-2847.js
@@ -1,3 +1,5 @@
+// Before https://github.com/nodejs/node/pull/2847 a child process trying
+// (asynchronously) to use the closed channel to it's creator caused a segfault.
 'use strict';
 
 const common = require('../common');
@@ -33,11 +35,14 @@ const server = net.createServer(function(s) {
       worker.send({}, s, callback);
     });
 
-    // Errors can happen if this connection
-    // is still happening while the server has been closed.
+    // https://github.com/nodejs/node/issues/3635#issuecomment-157714683
+    // ECONNREFUSED or ECONNRESET errors can happen if this connection is still
+    // establishing while the server has already closed.
+    // EMFILE can happen if the worker __and__ the server had already closed.
     s.on('error', function(err) {
       if ((err.code !== 'ECONNRESET') &&
-          ((err.code !== 'ECONNREFUSED'))) {
+          (err.code !== 'ECONNREFUSED') &&
+          (err.code !== 'EMFILE')) {
         throw err;
       }
     });