Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate toolbar button construction #102

Merged
merged 2 commits into from
Sep 10, 2014

Conversation

duhast
Copy link
Contributor

@duhast duhast commented Sep 10, 2014

Hi!
I've noted there was some unwanted CSS classes on the Preview button, so I've rewrote toolbar buttons creation routine in a jQuery-way.

Before:
screenshot 2014-09-10 02 53 32

After:
screenshot 2014-09-10 03 44 24

P.S. I use custom button styles, that's why my buttons doesn't look like standard BS3 flat buttons.

duhast pushed a commit to duhast/rails-bootstrap-markdown that referenced this pull request Sep 10, 2014
@acrobat
Copy link
Contributor

acrobat commented Sep 10, 2014

👍

@toopay
Copy link
Member

toopay commented Sep 10, 2014

@duhast thanks for spotting that culprit. Can you standarize the variable naming convention with the rest of the block?

@duhast
Copy link
Contributor Author

duhast commented Sep 10, 2014

Sure @toopay. Just to confirm - you mean to remove $ ?

@toopay
Copy link
Member

toopay commented Sep 10, 2014

Yes, and use more verbose camelCased word if necessary (buttonIcon - or buttonIconContainer - instead icon)

@duhast
Copy link
Contributor Author

duhast commented Sep 10, 2014

Done

toopay added a commit that referenced this pull request Sep 10, 2014
More accurate toolbar button construction
@toopay toopay merged commit df249e2 into refactory-id:master Sep 10, 2014
@toopay
Copy link
Member

toopay commented Sep 10, 2014

Thanks @duhast

@duhast
Copy link
Contributor Author

duhast commented Sep 10, 2014

You welcome 😃 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants