More accurate toolbar button construction #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duhast
pushed a commit
to duhast/rails-bootstrap-markdown
that referenced
this pull request
Sep 10, 2014
|
👍 |
|
@duhast thanks for spotting that culprit. Can you standarize the variable naming convention with the rest of the block? |
|
Sure @toopay. Just to confirm - you mean to remove |
|
Yes, and use more verbose camelCased word if necessary ( |
|
Done |
toopay
added a commit
that referenced
this pull request
Sep 10, 2014
More accurate toolbar button construction
|
Thanks @duhast |
|
You welcome 😃 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've noted there was some unwanted CSS classes on the Preview button, so I've rewrote toolbar buttons creation routine in a jQuery-way.
Before:
After:
P.S. I use custom button styles, that's why my buttons doesn't look like standard BS3 flat buttons.