Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup auto-publishing for Safari version #3686

Open
2 tasks
fregante opened this issue Oct 25, 2020 · 42 comments
Open
2 tasks

Setup auto-publishing for Safari version #3686

fregante opened this issue Oct 25, 2020 · 42 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt help wanted meta Related to Refined GitHub itself Please! ♥︎ Particularly useful features that everyone would love! safari Related to Safari only

Comments

@fregante
Copy link
Member

fregante commented Oct 25, 2020

Issuehunt badges

Outdated intro

Refined GitHub is now also compatible with Safari (#3677), but it's not available on the App Store nor it's signed.

Safari users 👋

If you're looking to use Refined GitHub for Safari, for the time being it's best to use https://github.com/lautis/refined-github-safari

Xcode developers 👋

We need your help to:

How to build

  1. Install XCode 12 and Safari 14

  2. In Safari, enable Allow Unsigned Extensions in the Develop menu.

  3. Run:

    npm install
    npm run build
    npm run pack:safari
    npm run start:safari
  4. In Safari, click on the extension icon while on GitHub.com to enable it.

You could also sign it locally following the instructions below: #3686 (comment)


IssueHunt Summary

Backers (Total: $200.01)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@fregante fregante added help wanted meta Related to Refined GitHub itself Please! ♥︎ Particularly useful features that everyone would love! safari Related to Safari only labels Oct 25, 2020
@fregante fregante mentioned this issue Oct 25, 2020
@fregante fregante pinned this issue Oct 25, 2020
@issuehunt-oss
Copy link

issuehunt-oss bot commented Nov 16, 2020

@darthshadow has funded $10.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Nov 16, 2020
@issuehunt-oss
Copy link

issuehunt-oss bot commented Nov 16, 2020

@fregante has funded $10.00 to this issue.


@fregante

This comment has been minimized.

@0-vortex

This comment has been minimized.

@fregante

This comment has been minimized.

@0-vortex
Copy link

Hey guys just finished reading the docs for fastlane and the great work over at lautis/refined-github-safari/fastlane

So far I have 1 issue related to certificates - looking at docs.fastlane.tools/actions/match I believe sharing a provisioning profile would reduce the safari github action to:

npm run build
bundle exec fastlane sign

Due to limitations I understand the appstore lane should be on a manual trigger to avoid potential double submit ?

If match is not appealing (overhead) the other simple solution would be to set up a CI machine with a temporary application password. I value this approach because it enables rapid development on a beta/staging lane with hardcoded Appfile values as described in docs.fastlane.tools/advanced/Appfile

While the above methods are friendly enough for non-apple developers to contribute on the extension, my main motivation is keeping the workflow logic (setting up ruby, node, auth and running commands) separated from fastlane and app store flows.

If that sounds good I would be happy to move forward with a CI provisioning profile and automated github action builds for a pre-production environment - this can be used as an artifact to solve spam lagging app store releases or just compare with live version.

TL;DR: Apple release process can be hacked quickly but I am not experienced enough in solving the credentials issue :D

Happy to know your thoughts !

@fregante fregante mentioned this issue Nov 26, 2020
5 tasks
@gingerbeardman

This comment has been minimized.

@lautis

This comment has been minimized.

@gingerbeardman

This comment has been minimized.

@sindresorhus
Copy link
Member

If match is not appealing (overhead) the other simple solution would be to set up a CI machine with a temporary application password. I value this approach because it enables rapid development on a beta/staging lane with hardcoded Appfile values as described in docs.fastlane.tools/advanced/Appfile

I prefer the CI machine approach. I would like the simplest setup possible.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Dec 12, 2020

An anonymous user has funded $20.00 to this issue.


@gibfahn

This comment has been minimized.

@markdorison
Copy link

To get Fastlane configured, we will need to provide Apple ID developer credentials. Is it safe to assume that the project maintainer (@sindresorhus), or a collaborator @sindresorhus trusts and specifically delegates to should handle this?

@fregante

This comment has been minimized.

@fregante fregante changed the title Setup auto-deployment for Safari version Setup auto-publishing for Safari version Dec 30, 2020
@L1cardo

This comment has been minimized.

@sindresorhus

This comment has been minimized.

@gingerbeardman

This comment has been minimized.

@fregante

This comment has been minimized.

@gingerbeardman

This comment has been minimized.

@ogirginc

This comment has been minimized.

@fregante

This comment has been minimized.

@gingerbeardman
Copy link

gingerbeardman commented Mar 5, 2021

I see that this test build 21.3.5 requires macOS 10.15 or higher.

It would be good if Safari 14 on macOS 10.14.6 could be supported, as previously mentioned: #3686 (comment)

Thank you

@gibfahn

This comment has been minimized.

@gingerbeardman

This comment has been minimized.

@sindresorhus

This comment has been minimized.

@sindresorhus

This comment has been minimized.

@fregante

This comment has been minimized.

@rakleed

This comment has been minimized.

@gingerbeardman

This comment has been minimized.

@j-f1

This comment has been minimized.

@yakov116

This comment has been minimized.

@renatobenks

This comment has been minimized.

@fregante

This comment has been minimized.

@L1cardo

This comment has been minimized.

@fregante

This comment has been minimized.

@renatobenks

This comment has been minimized.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 21, 2021

@fregante has funded $40.01 to this issue.


@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 5, 2021

@sindresorhus has funded $100.00 to this issue.


@wearhere

This comment has been minimized.

@yakov116

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt help wanted meta Related to Refined GitHub itself Please! ♥︎ Particularly useful features that everyone would love! safari Related to Safari only
Development

No branches or pull requests