Improve and fix remove-projects-tab

[yakov116]

Split remove-projects-tab into 2 parts.

1. addNewProjectLink()
2. removeProjectsTab()

Test on:
https://github.com/microsoft
https://github.com/twbs/bootstrap
https://github.com/babel

[fregante]

should isOrgRepoWithAccess be moved to the other module

Yes, but this is not an organization repo check, it's an organization check. It applies to: https://github.com/babel

I suggest renaming them to canUserEditRepo (from isRepoWithAccess) and canUserEditOrganization

isRepoWithAccess should still stay, but as a deprecated alias:

/** @deprecated use canUserEditRepo */
export const isRepoWithAccess = canUserEditRepo

[fregante]

This whole feature can be rewritten in 2 init functions:

1. addNewProjectLink
2. removeProjectsTab

They have very different conditions, however both depend on !projectsTab, I think:

function getProjectsTab() {
	return elementReady([
		'[data-hotkey="g b"]', // In organizations and repos
		'.user-profile-nav [href$="?tab=projects"]' // In user profiles
	].join());
}

[yakov116]

Blocked by refined-github/github-url-detection#3

[yakov116]

This needs more work. Dont review this PR yet (But I can still use refined-github/github-url-detection#3)

[yakov116]

Updated logic and first post.

Dont have a org with projects to test on.

[fregante]

This works, but there's a little big problem: counters are loaded after dom-ready so sometimes the tab is removed even on https://github.com/microsoft

[fregante]

This seems to work. Thoughts?

[yakov116]

Awesome! Very clean (love the emojis) 😄

[fregante]

🙌