-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint #3684
Lint #3684
Conversation
9096132
to
2a90b82
Compare
2a90b82
to
f9b36ea
Compare
What timezone are you in? |
Eastern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged once the few last few comments I left are resolved
It was incomplete
Co-authored-by: Federico <[email protected]>
Co-authored-by: Federico <[email protected]>
Likewise, we can change the v4 to automatically inject the current owner/name when it encounters an empty |
Agree but I was not sure how to implement it. Will try on the next round. |
I think it'd be something like this in query = query.replace('repository() {', `repository(owner: ${…} name: ${…}) {`) |
Wait though because #3695 changes the same lines |
Its not November yet... (at least in my time zone) 😃 |
I'll start adding ideas to "the last lint pr": |
api.v3
default torepos/${getRepoURL}
getPRRepositoryInfo
getRepoURL
to usegetPRRepositoryInfo