Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate cached_var to var(cache=True) #798

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

benedikt-bartscher
Copy link
Contributor

No description provided.

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure why the integration tests are failing.

I think we should leave a mention of rx.cached_var being the previous way to do this, so that people who see code using that can still find a reference in the docs.

@benedikt-bartscher
Copy link
Contributor Author

I added a small hint to the old partial decorator. Not sure why the integration tests are failing, i was wondering this as well. Maybe i'll look into it later.

@benedikt-bartscher
Copy link
Contributor Author

needs reflex-dev/reflex#3726

@benedikt-bartscher
Copy link
Contributor Author

@picklelo ci is passing now ✔️

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating!

@picklelo picklelo merged commit a3459b2 into reflex-dev:main Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants