-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate cached_var to var(cache=True) #798
migrate cached_var to var(cache=True) #798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, not sure why the integration tests are failing.
I think we should leave a mention of rx.cached_var
being the previous way to do this, so that people who see code using that can still find a reference in the docs.
I added a small hint to the old partial decorator. Not sure why the integration tests are failing, i was wondering this as well. Maybe i'll look into it later. |
needs reflex-dev/reflex#3726 |
@picklelo ci is passing now ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for updating!
No description provided.