Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate README.md file in Korean #2011

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

starcat37
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Documentation

Description

I have translated the README.md file into Korean and added links to the section for different languages.

@Lendemor
Copy link
Collaborator

Lendemor commented Oct 22, 2023

You've added the link in all other README, but I think you forgot to add in the main one :
https://github.com/reflex-dev/reflex/blob/main/README.md

@starcat37
Copy link
Contributor Author

starcat37 commented Oct 22, 2023

Oh I must have missed that one🥲🥲 Thank you for catching that!

I've made a new commit to include the missing link. Could you please review the changes?

Thanks😊

@Lendemor Lendemor merged commit bcbe3bb into reflex-dev:main Oct 23, 2023
1 check passed
@starcat37 starcat37 deleted the docs/korean branch October 23, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants