Improve Client-Side Routing on Page Not Found #3723

Manas1820 · 2024-07-31T02:44:07Z

Describe your changes.

The issue is well described in #3720 and also fixes it.

In the useClientSideRouting function, the routeNotFound state was incorrectly set to false even when the current route was actually not found. To address this, I added a hard check to verify the pathname after attempting a redirection. If the pathname remains /404 after the redirection attempt, the routeNotFound state is correctly set to true. This ensures that the correct 404 page is displayed when the route is genuinely not found.

Example is mentioned in the same issue's thread

Type of change

Bug fix (non-breaking change which fixes an issue)

New Feature Submission:

Does your submission pass the tests?
Have you linted your code locally prior to submission?

Changes To Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you successfully ran tests with your changes locally?

masenf

Thanks for your contribution. Seems to resolve the issue on my end.

Is there a reason why we check the router.pathname inside a chained function instead of before we even attempt the router.replace?

Manas1820 · 2024-07-31T20:24:53Z

@masenf Just did it to be completely sure, thought that when router.replace is called, it might initiate a client-side navigation that potentially changes the current route. By checking router.pathname after router.replace completes, we can be completely positive that we have reached the final state.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [reflex](https://reflex.dev) ([source](https://togithub.com/reflex-dev/reflex)) | project.dependencies | patch | `==0.5.8` -> `==0.5.9` | --- ### Release Notes <details> <summary>reflex-dev/reflex (reflex)</summary> ### [`v0.5.9`](https://togithub.com/reflex-dev/reflex/releases/tag/v0.5.9) [Compare Source](https://togithub.com/reflex-dev/reflex/compare/v0.5.8...v0.5.9) #### Bug Fixes - fix silly bug when style is set directly to breakpoints by [@adhami3310](https://togithub.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3719](https://togithub.com/reflex-dev/reflex/pull/3719) - Fix event actions like `stop_propagation` for recharts event triggers - \[REF-3203] Find a DOM event-like object in addEvents by [@masenf](https://togithub.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3706](https://togithub.com/reflex-dev/reflex/pull/3706) - fix initial_value for computed_var by [@benedikt-bartscher](https://togithub.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3726](https://togithub.com/reflex-dev/reflex/pull/3726) - add test for initial state dict by [@benedikt-bartscher](https://togithub.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3727](https://togithub.com/reflex-dev/reflex/pull/3727) - Improve Client-Side Routing on Page Not Found by [@Manas1820](https://togithub.com/Manas1820) in [https://github.com/reflex-dev/reflex/pull/3723](https://togithub.com/reflex-dev/reflex/pull/3723) - Use the new state name when setting `is_hydrated` to false by [@masenf](https://togithub.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3738](https://togithub.com/reflex-dev/reflex/pull/3738) - Use `._is_mutable()` to account for parent state proxy by [@masenf](https://togithub.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3739](https://togithub.com/reflex-dev/reflex/pull/3739) #### Doc Updates - Add comments to html by [@Alek99](https://togithub.com/Alek99) in [https://github.com/reflex-dev/reflex/pull/3731](https://togithub.com/reflex-dev/reflex/pull/3731) #### Var Refactor This release includes some new experimental features being developed incrementally in reflex.\_x.vars. - \[REF-3328] Implement **getitem** for ArrayVar by [@adhami3310](https://togithub.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3705](https://togithub.com/reflex-dev/reflex/pull/3705) - add type hinting to existing types by [@adhami3310](https://togithub.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3729](https://togithub.com/reflex-dev/reflex/pull/3729) **Full Changelog**: reflex-dev/reflex@v0.5.8...v0.5.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

Co-authored-by: coolstorm <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [reflex](https://reflex.dev) ([source](https://togithub.com/reflex-dev/reflex)) | project.dependencies | patch | `==0.5.8` -> `==0.5.9` | --- ### Release Notes <details> <summary>reflex-dev/reflex (reflex)</summary> ### [`v0.5.9`](https://togithub.com/reflex-dev/reflex/releases/tag/v0.5.9) [Compare Source](https://togithub.com/reflex-dev/reflex/compare/v0.5.8...v0.5.9) #### Bug Fixes - fix silly bug when style is set directly to breakpoints by [@adhami3310](https://togithub.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3719](https://togithub.com/reflex-dev/reflex/pull/3719) - Fix event actions like `stop_propagation` for recharts event triggers - \[REF-3203] Find a DOM event-like object in addEvents by [@masenf](https://togithub.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3706](https://togithub.com/reflex-dev/reflex/pull/3706) - fix initial_value for computed_var by [@benedikt-bartscher](https://togithub.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3726](https://togithub.com/reflex-dev/reflex/pull/3726) - add test for initial state dict by [@benedikt-bartscher](https://togithub.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3727](https://togithub.com/reflex-dev/reflex/pull/3727) - Improve Client-Side Routing on Page Not Found by [@Manas1820](https://togithub.com/Manas1820) in [https://github.com/reflex-dev/reflex/pull/3723](https://togithub.com/reflex-dev/reflex/pull/3723) - Use the new state name when setting `is_hydrated` to false by [@masenf](https://togithub.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3738](https://togithub.com/reflex-dev/reflex/pull/3738) - Use `._is_mutable()` to account for parent state proxy by [@masenf](https://togithub.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3739](https://togithub.com/reflex-dev/reflex/pull/3739) #### Doc Updates - Add comments to html by [@Alek99](https://togithub.com/Alek99) in [https://github.com/reflex-dev/reflex/pull/3731](https://togithub.com/reflex-dev/reflex/pull/3731) #### Var Refactor This release includes some new experimental features being developed incrementally in reflex.\_x.vars. - \[REF-3328] Implement **getitem** for ArrayVar by [@adhami3310](https://togithub.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3705](https://togithub.com/reflex-dev/reflex/pull/3705) - add type hinting to existing types by [@adhami3310](https://togithub.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3729](https://togithub.com/reflex-dev/reflex/pull/3729) **Full Changelog**: reflex-dev/reflex@v0.5.8...v0.5.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

* Add comments to html metadata component (#3731) * fix: add verification for path /404 (#3723) Co-authored-by: coolstorm <[email protected]> * Use the new state name when setting `is_hydrated` to false (#3738) * Use `._is_mutable()` to account for parent state proxy (#3739) When a parent state proxy is set, also allow child StateProxy._self_mutable to override the parent's `_is_mutable()`. * bump to 0.5.9 (#3746) * add message when installing requirements.txt is needed for chosen template during init (#3750) * #3752 bugfix add domain for XAxis (#3764) * fix appharness app_source typing (#3777) * fix import clash between connectionToaster and hooks.useState (#3749) * use different registry when in china, fixes #3700 (#3702) * do not reload compilation if using local app in AppHarness (#3790) * do not reload if using local app * Update reflex/testing.py Co-authored-by: Masen Furer <[email protected]> --------- Co-authored-by: Masen Furer <[email protected]> * Bump memory on relevant actions (#3781) Co-authored-by: Alek Petuskey <[email protected]> * [REF-3334] Validate Toast Props (#3793) * [REF-3536][REF-3537][REF-3541] Move chakra components into its repo(reflex-chakra) (#3798) * fix get_uuid_string_var (#3795) * minor State cleanup (#3768) * Fix code wrap in markdown (#3755) --------- Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Khaleel Al-Adhami <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]>

* fully migrate vars into new system * i hate rufffff (no i don't) * fix silly pright issues (except colormode and state) * remove all instances of Var.create * create immutable callable var and get rid of more base vars * implement hash for all functions * get reflex-web to compile * get it to compile reflex-web successfully * fix tests * fix pyi * use override from typing_extension * put plotly inside of a catch * dicts are unusable sadly * fix silly mistake * overload equals to special case immutable var * improve test_cond * solve more CI issues, down to 94 failures * down to 20 errors * down to 13 errors * pass all testcases * fix pyright issues * reorder things * use get origin more * use fixed_type logic * various optimizations * go back to passing test cases * use less boilerplate * remove unnecessary print message * remove weird comment * add test for html issue * add type ignore * fix another silly issue * override get all var data for var operations call * make integration tests pass * fix immutable call var * better logic for finding parent class * use even better logic for finding state wrt computedvar * only choose the ones that are defined in the same module * small dict to large dict * [REF-3591] Remove chakra-related files from immutable vars PR (#3821) * Add comments to html metadata component (#3731) * fix: add verification for path /404 (#3723) Co-authored-by: coolstorm <[email protected]> * Use the new state name when setting `is_hydrated` to false (#3738) * Use `._is_mutable()` to account for parent state proxy (#3739) When a parent state proxy is set, also allow child StateProxy._self_mutable to override the parent's `_is_mutable()`. * bump to 0.5.9 (#3746) * add message when installing requirements.txt is needed for chosen template during init (#3750) * #3752 bugfix add domain for XAxis (#3764) * fix appharness app_source typing (#3777) * fix import clash between connectionToaster and hooks.useState (#3749) * use different registry when in china, fixes #3700 (#3702) * do not reload compilation if using local app in AppHarness (#3790) * do not reload if using local app * Update reflex/testing.py Co-authored-by: Masen Furer <[email protected]> --------- Co-authored-by: Masen Furer <[email protected]> * Bump memory on relevant actions (#3781) Co-authored-by: Alek Petuskey <[email protected]> * [REF-3334] Validate Toast Props (#3793) * [REF-3536][REF-3537][REF-3541] Move chakra components into its repo(reflex-chakra) (#3798) * fix get_uuid_string_var (#3795) * minor State cleanup (#3768) * Fix code wrap in markdown (#3755) --------- Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Khaleel Al-Adhami <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * pyproject.toml: bump to 0.6.0a1 * pyproject.toml: depend on reflex-chakra>=0.6.0a New Var system support in reflex-chakra 0.6.0a1 * poetry.lock: relock dependencies * integration: bump listening timeout to 1200 seconds * integration: bump listening timeout to 1800 seconds * Use cached_var_no_lock to avoid ImmutableVar deadlocks (#3835) * Use cached_var_no_lock to avoid ImmutableVar deadlocks ImmutableVar subclasses will always return the same value for a _var_name or _get_all_var_data so there is no need to use a per-class lock to protect a cached attribute on an instance, and doing so actually is observed to cause deadlocks when a particular _cached_var_name creates new LiteralVar instances and attempts to serialize them. * remove unused module global --------- Co-authored-by: Masen Furer <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]>

* basic functionality * reorder page evaluation * Fix benchmark tests (#3822) * Upper bound for reflex-chakra dependency (#3824) * Upper bound for reflex-chakra dependency We have to make a breaking change in reflex-chakra, and it will happen in 0.6.0, so ensure that reflex 0.5.10 never installs the breaking version of reflex-chakra. * Relock deps * Add comments to DataList components (#3827) * fix: Adding missing comments to the data list * fix: Ran make pyi * fully migrate vars into new system (#3743) * fully migrate vars into new system * i hate rufffff (no i don't) * fix silly pright issues (except colormode and state) * remove all instances of Var.create * create immutable callable var and get rid of more base vars * implement hash for all functions * get reflex-web to compile * get it to compile reflex-web successfully * fix tests * fix pyi * use override from typing_extension * put plotly inside of a catch * dicts are unusable sadly * fix silly mistake * overload equals to special case immutable var * improve test_cond * solve more CI issues, down to 94 failures * down to 20 errors * down to 13 errors * pass all testcases * fix pyright issues * reorder things * use get origin more * use fixed_type logic * various optimizations * go back to passing test cases * use less boilerplate * remove unnecessary print message * remove weird comment * add test for html issue * add type ignore * fix another silly issue * override get all var data for var operations call * make integration tests pass * fix immutable call var * better logic for finding parent class * use even better logic for finding state wrt computedvar * only choose the ones that are defined in the same module * small dict to large dict * [REF-3591] Remove chakra-related files from immutable vars PR (#3821) * Add comments to html metadata component (#3731) * fix: add verification for path /404 (#3723) Co-authored-by: coolstorm <[email protected]> * Use the new state name when setting `is_hydrated` to false (#3738) * Use `._is_mutable()` to account for parent state proxy (#3739) When a parent state proxy is set, also allow child StateProxy._self_mutable to override the parent's `_is_mutable()`. * bump to 0.5.9 (#3746) * add message when installing requirements.txt is needed for chosen template during init (#3750) * #3752 bugfix add domain for XAxis (#3764) * fix appharness app_source typing (#3777) * fix import clash between connectionToaster and hooks.useState (#3749) * use different registry when in china, fixes #3700 (#3702) * do not reload compilation if using local app in AppHarness (#3790) * do not reload if using local app * Update reflex/testing.py Co-authored-by: Masen Furer <[email protected]> --------- Co-authored-by: Masen Furer <[email protected]> * Bump memory on relevant actions (#3781) Co-authored-by: Alek Petuskey <[email protected]> * [REF-3334] Validate Toast Props (#3793) * [REF-3536][REF-3537][REF-3541] Move chakra components into its repo(reflex-chakra) (#3798) * fix get_uuid_string_var (#3795) * minor State cleanup (#3768) * Fix code wrap in markdown (#3755) --------- Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Khaleel Al-Adhami <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * pyproject.toml: bump to 0.6.0a1 * pyproject.toml: depend on reflex-chakra>=0.6.0a New Var system support in reflex-chakra 0.6.0a1 * poetry.lock: relock dependencies * integration: bump listening timeout to 1200 seconds * integration: bump listening timeout to 1800 seconds * Use cached_var_no_lock to avoid ImmutableVar deadlocks (#3835) * Use cached_var_no_lock to avoid ImmutableVar deadlocks ImmutableVar subclasses will always return the same value for a _var_name or _get_all_var_data so there is no need to use a per-class lock to protect a cached attribute on an instance, and doing so actually is observed to cause deadlocks when a particular _cached_var_name creates new LiteralVar instances and attempts to serialize them. * remove unused module global --------- Co-authored-by: Masen Furer <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * guess_type: if the type is optional, treat it like it's "not None" (#3839) * guess_type: if the type is optional, treat it like it's "not None" When guessing the type for an Optional annotation, the Optional was already being stripped off, but this value was being ignored, except for error messages. So actually use the Optional-stripped value. * Strip Optional when casting Var .to * Fix double-quoting of defaultColorMode (#3840) If the user provided an `appearance` or `color_mode` value to `rx.theme`, then the resulting value ended up being double-double-quoted in the resulting JS output. Instead remove the quotes from the context.js.jinja2 and always pass appearance as a Var. * basic functionality * run pyright * fully migrate vars into new system (#3743) * fully migrate vars into new system * i hate rufffff (no i don't) * fix silly pright issues (except colormode and state) * remove all instances of Var.create * create immutable callable var and get rid of more base vars * implement hash for all functions * get reflex-web to compile * get it to compile reflex-web successfully * fix tests * fix pyi * use override from typing_extension * put plotly inside of a catch * dicts are unusable sadly * fix silly mistake * overload equals to special case immutable var * improve test_cond * solve more CI issues, down to 94 failures * down to 20 errors * down to 13 errors * pass all testcases * fix pyright issues * reorder things * use get origin more * use fixed_type logic * various optimizations * go back to passing test cases * use less boilerplate * remove unnecessary print message * remove weird comment * add test for html issue * add type ignore * fix another silly issue * override get all var data for var operations call * make integration tests pass * fix immutable call var * better logic for finding parent class * use even better logic for finding state wrt computedvar * only choose the ones that are defined in the same module * small dict to large dict * [REF-3591] Remove chakra-related files from immutable vars PR (#3821) * Add comments to html metadata component (#3731) * fix: add verification for path /404 (#3723) Co-authored-by: coolstorm <[email protected]> * Use the new state name when setting `is_hydrated` to false (#3738) * Use `._is_mutable()` to account for parent state proxy (#3739) When a parent state proxy is set, also allow child StateProxy._self_mutable to override the parent's `_is_mutable()`. * bump to 0.5.9 (#3746) * add message when installing requirements.txt is needed for chosen template during init (#3750) * #3752 bugfix add domain for XAxis (#3764) * fix appharness app_source typing (#3777) * fix import clash between connectionToaster and hooks.useState (#3749) * use different registry when in china, fixes #3700 (#3702) * do not reload compilation if using local app in AppHarness (#3790) * do not reload if using local app * Update reflex/testing.py Co-authored-by: Masen Furer <[email protected]> --------- Co-authored-by: Masen Furer <[email protected]> * Bump memory on relevant actions (#3781) Co-authored-by: Alek Petuskey <[email protected]> * [REF-3334] Validate Toast Props (#3793) * [REF-3536][REF-3537][REF-3541] Move chakra components into its repo(reflex-chakra) (#3798) * fix get_uuid_string_var (#3795) * minor State cleanup (#3768) * Fix code wrap in markdown (#3755) --------- Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Khaleel Al-Adhami <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * pyproject.toml: bump to 0.6.0a1 * pyproject.toml: depend on reflex-chakra>=0.6.0a New Var system support in reflex-chakra 0.6.0a1 * poetry.lock: relock dependencies * integration: bump listening timeout to 1200 seconds * integration: bump listening timeout to 1800 seconds * Use cached_var_no_lock to avoid ImmutableVar deadlocks (#3835) * Use cached_var_no_lock to avoid ImmutableVar deadlocks ImmutableVar subclasses will always return the same value for a _var_name or _get_all_var_data so there is no need to use a per-class lock to protect a cached attribute on an instance, and doing so actually is observed to cause deadlocks when a particular _cached_var_name creates new LiteralVar instances and attempts to serialize them. * remove unused module global --------- Co-authored-by: Masen Furer <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * basic functionality * reorder page evaluation * fully migrate vars into new system (#3743) * fully migrate vars into new system * i hate rufffff (no i don't) * fix silly pright issues (except colormode and state) * remove all instances of Var.create * create immutable callable var and get rid of more base vars * implement hash for all functions * get reflex-web to compile * get it to compile reflex-web successfully * fix tests * fix pyi * use override from typing_extension * put plotly inside of a catch * dicts are unusable sadly * fix silly mistake * overload equals to special case immutable var * improve test_cond * solve more CI issues, down to 94 failures * down to 20 errors * down to 13 errors * pass all testcases * fix pyright issues * reorder things * use get origin more * use fixed_type logic * various optimizations * go back to passing test cases * use less boilerplate * remove unnecessary print message * remove weird comment * add test for html issue * add type ignore * fix another silly issue * override get all var data for var operations call * make integration tests pass * fix immutable call var * better logic for finding parent class * use even better logic for finding state wrt computedvar * only choose the ones that are defined in the same module * small dict to large dict * [REF-3591] Remove chakra-related files from immutable vars PR (#3821) * Add comments to html metadata component (#3731) * fix: add verification for path /404 (#3723) Co-authored-by: coolstorm <[email protected]> * Use the new state name when setting `is_hydrated` to false (#3738) * Use `._is_mutable()` to account for parent state proxy (#3739) When a parent state proxy is set, also allow child StateProxy._self_mutable to override the parent's `_is_mutable()`. * bump to 0.5.9 (#3746) * add message when installing requirements.txt is needed for chosen template during init (#3750) * #3752 bugfix add domain for XAxis (#3764) * fix appharness app_source typing (#3777) * fix import clash between connectionToaster and hooks.useState (#3749) * use different registry when in china, fixes #3700 (#3702) * do not reload compilation if using local app in AppHarness (#3790) * do not reload if using local app * Update reflex/testing.py Co-authored-by: Masen Furer <[email protected]> --------- Co-authored-by: Masen Furer <[email protected]> * Bump memory on relevant actions (#3781) Co-authored-by: Alek Petuskey <[email protected]> * [REF-3334] Validate Toast Props (#3793) * [REF-3536][REF-3537][REF-3541] Move chakra components into its repo(reflex-chakra) (#3798) * fix get_uuid_string_var (#3795) * minor State cleanup (#3768) * Fix code wrap in markdown (#3755) --------- Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Khaleel Al-Adhami <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * pyproject.toml: bump to 0.6.0a1 * pyproject.toml: depend on reflex-chakra>=0.6.0a New Var system support in reflex-chakra 0.6.0a1 * poetry.lock: relock dependencies * integration: bump listening timeout to 1200 seconds * integration: bump listening timeout to 1800 seconds * Use cached_var_no_lock to avoid ImmutableVar deadlocks (#3835) * Use cached_var_no_lock to avoid ImmutableVar deadlocks ImmutableVar subclasses will always return the same value for a _var_name or _get_all_var_data so there is no need to use a per-class lock to protect a cached attribute on an instance, and doing so actually is observed to cause deadlocks when a particular _cached_var_name creates new LiteralVar instances and attempts to serialize them. * remove unused module global --------- Co-authored-by: Masen Furer <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Elijah Ahianyo <[email protected]> * guess_type: if the type is optional, treat it like it's "not None" (#3839) * guess_type: if the type is optional, treat it like it's "not None" When guessing the type for an Optional annotation, the Optional was already being stripped off, but this value was being ignored, except for error messages. So actually use the Optional-stripped value. * Strip Optional when casting Var .to * run format * use original mp * evaluate page regardless * use old typing * dangit pydantic * i have two braincells and they are NOT collaborating * adjust testcases * always add the upload endpoint * retrieve upload but after evaluate component * check against none Co-authored-by: Masen Furer <[email protected]> * make it var * fix page title * don't change style.py * fix counter * remove duplicated logic --------- Co-authored-by: Elijah Ahianyo <[email protected]> Co-authored-by: Masen Furer <[email protected]> Co-authored-by: elvis kahoro <[email protected]> Co-authored-by: Alek Petuskey <[email protected]> Co-authored-by: Manas Gupta <[email protected]> Co-authored-by: coolstorm <[email protected]> Co-authored-by: Thomas Brandého <[email protected]> Co-authored-by: Shubhankar Dimri <[email protected]> Co-authored-by: benedikt-bartscher <[email protected]> Co-authored-by: Alek Petuskey <[email protected]>

fix: add verification for path /404

8521d9d

Manas1820 mentioned this pull request Jul 31, 2024

[REF-3448] 404 not rendering #3720

Closed

masenf reviewed Jul 31, 2024

View reviewed changes

Lendemor approved these changes Aug 4, 2024

View reviewed changes

masenf merged commit c7e3052 into reflex-dev:main Aug 5, 2024
47 checks passed

benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request Aug 11, 2024

fix: add verification for path /404 (reflex-dev#3723)

45de8cd

Co-authored-by: coolstorm <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Client-Side Routing on Page Not Found #3723

Improve Client-Side Routing on Page Not Found #3723

Manas1820 commented Jul 31, 2024 •

edited

Loading

masenf left a comment

Manas1820 commented Jul 31, 2024

Improve Client-Side Routing on Page Not Found #3723

Improve Client-Side Routing on Page Not Found #3723

Conversation

Manas1820 commented Jul 31, 2024 • edited Loading

Describe your changes.

Type of change

New Feature Submission:

Changes To Core Features:

masenf left a comment

Choose a reason for hiding this comment

Manas1820 commented Jul 31, 2024

Manas1820 commented Jul 31, 2024 •

edited

Loading