Bug fix rx.toast. Allow passing title
kwarg
#3857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Have you followed the guidelines stated in CONTRIBUTING.md file?
Yes
Have you checked to ensure there aren't any other open Pull Requests for the desired changed?
Yes
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
No -- Did not find any existing tests for toasts, and wasn't sure where to put them.
After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR. -- Done
b. Describe your changes.
title
to theToastProps(PropsBase)
so that a validation error isn't raised iftitle
is passed explicitlymessage
defualt to an empty string fortoast.info
,toast.error
, etc. -- Note: A error is already raised inToaster.send_toast
if message is empty and title/description are not providedc. Put
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if such).title
prop passed explicitly in0.5.10
#3854Note: I tested manually (in an example app) with these examples:
I did not find an obvious place to add real unit tests for this. I'm also not sure how I would go about that outside of AppHarness tests.