Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventFnArgMismatch fix to support defaults args #4004

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

LeoGrosjean
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

try to figure out how to, started to edit test_chain_event but then I realised it was not testing what I was coding.... so no test :(

@LeoGrosjean
Copy link
Contributor Author

closes #4003

@LeoGrosjean
Copy link
Contributor Author

Not sure about pertinence of my last commit, I did it to please darglint

from

def check_fn_match_arg_spec(fn: Callable, arg_spec: ArgsSpec):

to

def check_fn_match_arg_spec(fn: Callable | callable, arg_spec: ArgsSpec | Any):

But parent scope is

call_event_fn(fn: Callable, arg_spec: ArgsSpec)

And it uses same inputs, code has been split for functionnal reason

adhami3310
adhami3310 previously approved these changes Sep 26, 2024
@adhami3310
Copy link
Member

Thank you for your contribution! We will merge it after the tests pass ;)

@adhami3310 adhami3310 merged commit 60276cf into reflex-dev:main Sep 26, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants