[IMPL] - added support for sass and scss stylesheet languages #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file
picklelo
reviewed
Nov 4, 2024
adhami3310
reviewed
Nov 7, 2024
adhami3310
requested changes
Nov 7, 2024
* improve typing for serializer decorator * use wrapped logic * dang it darglint --------- Co-authored-by: Khaleel Al-Adhami <[email protected]>
* Add Missing Table props * add more props
Co-authored-by: simon <[email protected]>
* Codeblock cleanup in markdown * Initial approach to getting this working with rx.memo and reflex web * abstract the map var logic * the tests are not valid + pyright fix * darglint fix * Add unit tests plus mix components * pyi run * rebase on main * fix darglint * testing different OS * revert * This should fix it. Right? * Fix tests * minor fn signature fix * use ArgsFunctionOperation * use destructured args and pass the tests * fix remaining unit tests * fix pyi files * rebase on main * move language regex on codeblock to markdown * fix tests --------- Co-authored-by: Khaleel Al-Adhami <[email protected]>
These are useful for typing purposes and should be exposed at the top level to avoid requiring deep imports from subpackages that we may need to change later.
|
Sorry, that's why I can't see the error... Unit tests, cp312
Unit tests, cp310
|
Units tests
|
Attempting to initialize relationship fields in a sqlmodel model throws an error, so only pass defined pydantic __fields__ if the type is a Model.
|
well, for the |
* Astral 0.5.0 path change https://github.com/astral-sh/uv/releases Use XDG (i.e. ~/.local/bin) instead of the Cargo home directory in the installer * Fix path in production-app-platform example --------- Co-authored-by: Masen Furer <[email protected]>
adhami3310
reviewed
Nov 12, 2024
| @@ -165,7 +239,7 @@ def test_compile_stylesheets_exclude_tailwind(tmp_path, mocker): | |||
|
|
|||
| assert compiler.compile_root_stylesheet(stylesheets) == ( | |||
| str(Path(".web") / "styles" / "styles.css"), | |||
| "@import url('../public/styles.css'); \n", | |||
| "@import url('./styles.css'); \n", | |||
There was a problem hiding this comment.
are you sure this won't break anything?
There was a problem hiding this comment.
I don't know where this could cause a problem, since all the supported stylesheet files in the app/assets directories and subdirectories are copied or compiled and saved in the .web/styles directory and no longer in the .web/public directories.
and also, I checked the second batch of the tests/integration group and the tests/integration/test_tailwind.py (which is the only one to have tests impacted by the changes) passed the tests without any errors, which is why I don't understand the error in the first batch of the tests/integration group.
* redesign error boundary screen * pyi time * add color * i hate python 3.9
* Temporarily downpin @radix-ui/themes <3.1.5 A visual/style regression was introduced in @radix-ui/themes 3.1.5 as described in radix-ui/themes#627 which reflex needs to avoid. * Get expected radix library version from component
…eflex-dev#4371) Because of some dodgy logic in Base.get_value and State.dict / State.get_delta when the value of some state var X happened to be the name of another var in the state Y, then the value for X would be returned as the value of Y. wat. Fixes reflex-dev#4369
- better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file
…/KronosDev-Pro/reflex into add-sass-scss-stylesheet-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
New Feature Submission:
Changes To Core Features: