Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bound method as event handler #4348

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow bound method as event handler #4348

wants to merge 3 commits into from

Conversation

benedikt-bartscher
Copy link
Contributor

No description provided.

@benedikt-bartscher benedikt-bartscher changed the title subtract 1 arg if the method is a bound method Allow bound method as event handler Nov 10, 2024
@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review November 10, 2024 22:30
@adhami3310
Copy link
Member

We have this behavior already in the code? That's the number_of_bound_args argument.

@adhami3310
Copy link
Member

Also, in a case like this, tests would be appreciated to highlight if the existing code for this has regressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benedikt-bartscher @adhami3310