💥 update: use syscall.Errno-based error code #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaukas Wang <[email protected]>
Signed-off-by: Gaukas Wang <[email protected]>
It is no longer meaningful to keep an internal/wasm package for just one single struct, plus the struct WazeroModuleConfigFactory is meant to be exported. Signed-off-by: Gaukas Wang <[email protected]>
erikziyunchi
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we propose using
internal/wasip1instead ofinternal/wasmand re-implement the error code used for water in communication with WATMs.A
water-rspull request demonstrating the same change will be raised separately and is now covered by @erikziyunchi.