⭐ feat: enable on-disk compilation cache by default #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the bootstrapping speed, which has become a major overhead, we will cache the compiled WebAssembly module. Given that it is usually the case that every program importing WATER will be only using one or few WebAssembly modules, an in-memory cache plus an on-disk cache should suffice.
This also prevents a possible bug where if the runtime is reused to compile the same WebAssembly module for multiple times and the first one is closed after the latter ones are built but before (functions from) them are getting called, an error will be caused due to the cache is missing (deleted when the first instance is closed).
Close #34.