Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 breaking: fix, cleanup, and rename non-API function #47

Merged
merged 8 commits into from
Feb 10, 2024
Merged

💥 breaking: fix, cleanup, and rename non-API function #47

merged 8 commits into from
Feb 10, 2024

Commits on Feb 10, 2024

  1. docs: cleanup docs and fix bad function naming 

    This introduces a few breaking changes by renaming some of the exported functions. Affected functions are not considered a part of WATER API.

Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    cab7506 View commit details
    Browse the repository at this point in the history

  2. new: add CODEOWNERS 

    Add CODEOWNERS to automatically request code review on new pull requests.

Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9574b67 View commit details
    Browse the repository at this point in the history

  3. update: bump go version used by GitHub Actions 

    Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    610ba56 View commit details
    Browse the repository at this point in the history

  4. example: formalize WATM examples 

    Use optimized Rust/Go-based WATM.
Replacing WATMs under testdata with TinyGo-based ones.

Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    bbd37ed View commit details
    Browse the repository at this point in the history

  5. fix: ECANCELED returned by worker considered error 

    Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    d1f7190 View commit details
    Browse the repository at this point in the history

  6. 💥 breaking: UnimplementedConn is not Conn 

    UnimplementedConn does not need to implement `net.Conn`, since it is the most basic type instead of an extension introduced by WATER.

Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5449df3 View commit details
    Browse the repository at this point in the history

  7. 💥 breaking: UnimplementedListener 

    UnimplementedListener does not need to implement `net.Listener` since it is a basic type. The goal is to cover the extension added by WATER, so it should only implement non-standard library interfaces.

Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    0405766 View commit details
    Browse the repository at this point in the history

  8. lint: mustEmbedUnimplemented nolint unused 

    Signed-off-by: Gaukas Wang <[email protected]>
    @gaukas
    gaukas committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    8cfb4e3 View commit details
    Browse the repository at this point in the history