Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: allow config builder skip transport module #62

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

gaukas
Copy link
Contributor

@gaukas gaukas commented Mar 15, 2024

Avoid check and parse for TransportModuleBin and TransportModuleConfig when the target Config has each set.

This allows restricted development environment (such as WaterMob) or target (majorly mobile platforms) to use config builder with better flexibility.

@gaukas gaukas marked this pull request as ready for review March 15, 2024 01:09
Avoid check and parse for TransportModuleBin and TransportModuleConfig when the target Config has each set.

Signed-off-by: Gaukas Wang <[email protected]>
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaukas gaukas merged commit ec93ace into master Mar 15, 2024
15 checks passed
@gaukas gaukas deleted the config-builder-prefilled-bin branch March 16, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants