fix: serialization ver 0.6 for enum with default

refractproject · Jun 11, 2019 · e2f6de6 · e2f6de6
1 parent 7945b8b
commit e2f6de6
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Minim Changelog
 
+## 0.23.4 (2019-06-11)
+
+### Bug Fixes
+
+- Fixes serialisation of default values in enumerations in 
+  Refract JSON 0.6 serialisation.
+
 ## 0.23.3 (2019-04-06)
 
 ### Enhancements

diff --git a/lib/serialisers/JSON06Serialiser.js b/lib/serialisers/JSON06Serialiser.js
@@ -116,7 +116,9 @@ module.exports = class JSON06Serialiser extends JSONSerialiser {
     let samples = attributes.get('samples') || new this.namespace.elements.Array([]);
 
     if (defaultValue && defaultValue.content) {
-      defaultValue.content.attributes.remove('typeAttributes');
+      if (defaultValue.content.attributes) {
+        defaultValue.content.attributes.remove('typeAttributes');
+      }
       // Wrap default in array (not sure it is really needed because tests pass without this line)
       attributes.set('default', new this.namespace.elements.Array([defaultValue.content]));
     }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "minim",
-  "version": "0.23.3",
+  "version": "0.23.4",
   "description": "A library for interacting with JSON through Refract elements",
   "main": "lib/minim.js",
   "scripts": {

diff --git a/test/serialisers/JSON06Serialiser-test.js b/test/serialisers/JSON06Serialiser-test.js
@@ -387,6 +387,28 @@ describe('JSON 0.6 Serialiser', () => {
       });
     });
 
+    it('serialises enum with default', () => {
+      const defaultElement = new minim.elements.String('one');
+      const enumeration = new minim.Element();
+      enumeration.element = 'enum';
+      enumeration.attributes.set('default', defaultElement);
+
+      const result = serialiser.serialise(enumeration);
+
+      expect(result).to.deep.equal({
+        element: 'enum',
+        attributes: {
+          default: [
+            {
+              element: 'string',
+              content: 'one',
+            },
+          ],
+        },
+        content: [],
+      });
+    });
+
     it('serialises enum with fixed values', () => {
       const defaultElement = new minim.Element(new minim.elements.String('North'));
       defaultElement.element = 'enum';