Replaced Flake8 with Ruff #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regebro
reviewed
Oct 10, 2023
tzlocal/unix.py
Outdated
| @@ -94,7 +94,7 @@ def _get_localzone_name(_root="/"): | |||
| for filename in ("etc/sysconfig/clock", "etc/conf.d/clock"): | |||
| tzpath = os.path.join(_root, filename) | |||
| try: | |||
| with open(tzpath, "rt") as tzfile: | |||
There was a problem hiding this comment.
Can we skip that UP015 rule? I like having the parameters there even if they are default.
regebro
reviewed
Oct 10, 2023
| @@ -5,13 +5,12 @@ | |||
| get_localzone, | |||
| get_localzone_name, | |||
| reload_localzone, | |||
| ) # pragma: no cover | |||
There was a problem hiding this comment.
OK; I found a syntax for this both black and ruff like, I'll add that back later.
There was a problem hiding this comment.
Do you really want to ignore coverage here rather than just collect and combine from runs on multiple operating systems?
There was a problem hiding this comment.
We can try that, IIRC coverage didn't handle that correctly. Then again I don't have 100% coverage anyway so I guess it doesn't really matter.
|
Except for that UP015 rule, this looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff made some stylistic changes. I hope that's not an issue.