don't remove m2w64_ prefix in stdlib piggyback
#2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently this only considers |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2551 +/- ##
=======================================
Coverage 69.88% 69.88%
=======================================
Files 105 105
Lines 10597 10597
=======================================
Hits 7406 7406
Misses 3191 3191 ☔ View full report in Codecov by Sentry. |
h-vetinari
commented
May 7, 2024
| @@ -178,8 +178,8 @@ def _process_section(output_index, attrs, lines): | |||
| if line_compiler_c and line_compiler_m2c: | |||
There was a problem hiding this comment.
This wouldn't fire if a recipe only uses {{ compiler("m2w64_c") }} on windows and no other compilers elsewhere. If someone has a case of such a recipe, I can add it as a test and loosen the restriction here.
|
LGTM! thank you! |
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2547