Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable cross-compilation by default #2946

Closed
wants to merge 2 commits into from
Closed

Conversation

beckermr
Copy link
Contributor

Description:

This PR turns on cross-compilation for aarch64+ppc64le by default.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

closes #2930

@beckermr
Copy link
Contributor Author

pre-commit.ci autofix

@beckermr
Copy link
Contributor Author

@isuruf can you look at this to make sure the selection of minimigrators I have added makes sense?

@isuruf
Copy link
Member

isuruf commented Aug 22, 2024

The mini-migrators probably should have better filter functions to skip any feedstock that has cross-compilation enabled for some other platform. Applying them the second time is not a no-op. i.e. f(f(x)) != f(x)

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (41dac68) to head (5e6eeba).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2946   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         115      115           
  Lines       12214    12214           
=======================================
  Hits         9462     9462           
  Misses       2752     2752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr
Copy link
Contributor Author

closing since travis is working

@beckermr beckermr closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch arch migrator to cross-compilation by default
2 participants