Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Git-6) Use new Git Backend in Entire auto_tick flow #3004

Merged
merged 10 commits into from
Oct 19, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Sep 16, 2024

Description:

Building upon #3003, this replaces the remaining auto_tick logic to use the new git backend.
Notably, this PR ensures that the new backend is used for opening PRs and commenting on PRs.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

#3003 should be merged first.

@ytausch
Copy link
Contributor Author

ytausch commented Sep 16, 2024

@0xbe7a I think this is worth reviewing, even with limited knowledge of the codebase

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 92.77108% with 36 lines in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (621910b) to head (c37ea4f).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/auto_tick.py 15.78% 16 Missing ⚠️
conda_forge_tick/git_utils.py 88.98% 13 Missing ⚠️
tests/test_git_utils.py 98.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   76.15%   77.01%   +0.86%     
==========================================
  Files         120      120              
  Lines       12942    13201     +259     
==========================================
+ Hits         9856    10167     +311     
+ Misses       3086     3034      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytausch
Copy link
Contributor Author

ytausch commented Oct 14, 2024

Matt, FYI: Bela is no longer mentoring me, therefore I ping @pavelzw for an additional review.

conda_forge_tick/utils.py Outdated Show resolved Hide resolved
conda_forge_tick/git_utils.py Outdated Show resolved Hide resolved
conda_forge_tick/models/pr_json.py Show resolved Hide resolved
conda_forge_tick/git_utils.py Show resolved Hide resolved
tests/test_git_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. One todo item is to search the code base for any functions you have removed to ensure they are not used anywhere else.

@ytausch
Copy link
Contributor Author

ytausch commented Oct 18, 2024

Thank you! I just verified that no removed function is used in the regro or conda-forge organization via a quick GitHub search.

@ytausch ytausch requested a review from beckermr October 18, 2024 21:26
@beckermr beckermr merged commit 27561c5 into regro:main Oct 19, 2024
8 checks passed
@ytausch ytausch deleted the continue-git-backend-part-6 branch October 19, 2024 15:21
@beckermr
Copy link
Contributor

We're seeing errors in pushing to repos with this so I am going to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants