resize observer option #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdiab
force-pushed
the
osdiab/resize-observer-arg
branch
from
8e85731
to
1d20575
Compare
osdiab
force-pushed
the
osdiab/resize-observer-arg
branch
from
1d20575
to
ab49a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Closes #24
resize-observer-polyfillas a dev dep since it's bundled with flow and typescript typings for ResizeObserver to use (it’s not available in the standard TypeScript libs since it’s still not a confirmed spec yet), though can just inline those if we don't want to include it as a depstill ensuring this works locally, having some issues with getting it to lazy load as in the readme changes i made
EDIT: it does work, just need to wrap the set state call in a function;
ResizeObserveris a function sosetState()interprets it as a state reducer, which is not what we're trying to achieve. fixing the READMEEDIT 2: done