Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(example of Netlify image previews) ignore netlify folder #195

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

bsweger
Copy link
Collaborator

@bsweger bsweger commented Apr 2, 2024

Resolves #175

This small change is meant to demonstrate the Netlify previews. Note that there are two preview comments on this PR because I accidentally configured two reichlab.io sites in Netlify.

I've deleted one of the sites, so future PRs will have a single preview. The site with the 👎 reaction is the deleted one, and that preview link no longer works.

After chatting with @nickreich, we agreed that our eventual goal is switching site hosting from GitHub pages to Netlify, so we'll no longer need a "shadow" Netlify deployment just to get the site previews. We'll schedule some time to do that.

Additional background: the Netlify setup that makes this work.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for reichlab ready!

Name Link
🔨 Latest commit 3efa45e
🔍 Latest deploy log https://app.netlify.com/sites/reichlab/deploys/660c0ef59dd5710008033530
😎 Deploy Preview https://deploy-preview-195--reichlab.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 2, 2024

Reichlab preview ready for review

Name Link
🔨 Latest commit 3efa45e
🔍 Latest deploy log https://app.netlify.com/sites/reichlab-io/deploys/660c0ef572a8b300087f41c7
😎 Deploy Preview https://deploy-preview-195--reichlab-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bsweger bsweger requested a review from nickreich April 2, 2024 16:51
@bsweger bsweger changed the title ignore netlify folder (example of Netlify image previews) ignore netlify folder Apr 2, 2024
Copy link
Member

@nickreich nickreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview looks good to me! I love how the PR comment really clearly shows the links to the preview.

@bsweger bsweger merged commit 05135ae into source Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add netlify integrataion for preview builds on PRs
2 participants