Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo (backgroud) in text function #73

Closed
wants to merge 1 commit into from
Closed

Conversation

m42e
Copy link

@m42e m42e commented Oct 25, 2016

No description provided.

@vadmium
Copy link
Collaborator

vadmium commented Oct 25, 2016

Looks good to me. Though I notice the rect() function has the same spelling error.

It looks like nobody tested setting the background field. I wonder if it would be okay to get rid of the *args and **kwargs parameters to these functions, which would make this kind of error more obvious.

@m42e
Copy link
Author

m42e commented Oct 26, 2016

Yes, I saw the rect has the same typo. But besides the typo the background is ignored anyhow, because no fillled box will be drawn. :X

I'm not sure is this just a plain 'copy' of the pho version or is further development here welcome?

Edit:
The Template is not part of the PHP fpdf, so I think it would be ok. Please let this unmerged, and I'll have a closer look at it.

@m42e
Copy link
Author

m42e commented Oct 26, 2016

Fixed within #74.

@m42e m42e closed this Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants