-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print test output properly with --win
and --no-win
#37
base: master
Are you sure you want to change the base?
Conversation
The tests fail on Travis. From your description it seems that all but the |
The |
What is the
What does "error: stdin is not a tty" even mean in this case? And why does it happen? |
I don't fully understand what a tty is, but broadly speaking, it means an interactive terminal. If stdin and stdout are redirected to/from a pipe or a file, then it's not a tty, and you can't do things like run an editor because there's no terminal on which to display the interface. I assume that ecukes is running the tests in a context where stdin and stdout are redirected, so The As I said, the tests are suboptimal. I'm not sure if it's possible to get these options working correctly in ecukes. |
Sorry, forgot about this. I don't mind your solution, but the reason I asked before was that the tests does not pass at all. |
I just don't think it's possible for the |
Too bad, but let's just ignore the tests then. We have other tests that make sure this won't break anything at least. |
Ok, so I guess I'll remove the tests for |
Yes, let's do so. |
82307a4
to
6ab5e65
Compare
0f42819
to
da1f118
Compare
This should allow Cask to install the package using Git.
da1f118
to
05b13eb
Compare
25dd45f
to
6307995
Compare
6307995
to
3b91393
Compare
I ran into an issue where an error during file loading when running with |
Any chance we can get this merged? I currently have a build failing only in CI, so I can really use some proper output now. |
Fixes #24. However, the tests are suboptimal. When running ecukes, stdin isn't a tty, so ert-runner with
--no-win
doesn't work. I had to usescript
to trick the emacs subprocess into thinking stdin was a tty in order to get it to work. For the--win
option, I couldn't get the test to work at all. It just opened an empty Emacs window and stopped until I quit manually, at which point the test failed. However, when I ran the tests of my own package (ido-ubiquitous) withert-runner --win
, they worked perfectly.