Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctype "expert-commentary" to BSI documents and model #19

Closed
ronaldtse opened this issue Feb 16, 2023 · 9 comments
Closed

Add doctype "expert-commentary" to BSI documents and model #19

ronaldtse opened this issue Feb 16, 2023 · 9 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ronaldtse
Copy link

ronaldtse commented Feb 16, 2023

There is a doctype called "expert-commentary" ("Expert commentary") that is published.

The identifier is as:

{base ID} ExComm

Just like:

  • BS EN ISO 13485:2016 ExComm
  • BS 7273-4:2015+A1:2021 ExComm

This is a blocker to:

@ronaldtse ronaldtse added the enhancement New feature or request label Feb 16, 2023
@ronaldtse ronaldtse added the bug Something isn't working label Feb 16, 2023
@ronaldtse
Copy link
Author

Actually this is also a BUG:

* [[[BS_7273_4_2015,hidden(BS 7273-4:2015)]]]

Currently fetches
Screenshot 2023-02-16 at 3 19 46 PM

Relaton fetch:

$ bundle exec relaton fetch "BS 7273-4:2015"
[relaton-bsi] ("BS 7273-4:2015") fetching...
[relaton-iso-bib] WARNING: invalid doctype: publication
[relaton-iso-bib] Allowed doctypes are: british-standard, draft-for-development, published-document, privately-subscribed-standard, publicly-available-specification, flex-standard, international-standard, technical-specification, technical-report, guide, international-workshop-agreement, industry-technical-agreement, standard, european-workshop-agreement, fast-track-standard
[relaton-bsi] ("BS 7273-4:2015") found BS 7273-4:2015 ExComm (Fire)
[relaton-iso-bib] WARNING: invalid doctype: publication
[relaton-iso-bib] Allowed doctypes are: british-standard, draft-for-development, published-document, privately-subscribed-standard, publicly-available-specification, flex-standard, international-standard, technical-specification, technical-report, guide, international-workshop-agreement, industry-technical-agreement, standard, european-workshop-agreement, fast-track-standard
<bibdata type="standard" schema-version="v1.2.1">
  <fetched>2023-02-16</fetched>
  <title type="title-main" format="text/plain" language="en" script="Latn">Expert Commentary on BS 7273‑4:2015, Code of practice for the operation of fire protection measures</title>
  <title type="main" format="text/plain" language="en" script="Latn">Expert Commentary on BS 7273‑4:2015, Code of practice for the operation of fire protection measures</title>
  <uri type="src">https://shop.bsigroup.com/products/expert-commentary-on-bs-7273-4-2015-code-of-practice-for-the-operation-of-fire-protection-measures</uri>
  <docidentifier type="BSI" primary="true">BS 7273-4:2015 ExComm (Fire)</docidentifier>
  <date type="published">
    <on>2017-05-01</on>
  </date>
  <contributor>
    <role type="publisher"/>
    <organization>
      <name>British Standards Institution</name>
      <abbreviation>BSI</abbreviation>
      <uri>https://www.bsigroup.com/</uri>
    </organization>
  </contributor>
  <language>en</language>
  <script>Latn</script>
  <abstract format="text/plain" language="en" script="Latn"/>
  <status>
    <stage>Current</stage>
  </status>
  <copyright>
    <from>2017</from>
    <owner>
      <organization>
        <name>British Standards Institution</name>
        <abbreviation>BSI</abbreviation>
        <uri>https://www.bsigroup.com/</uri>
      </organization>
    </owner>
  </copyright>
  <place>London</place>
  <ext schema-version="v1.0.0">
    <doctype>publication</doctype>
    <editorialgroup>
      <technical-committee>FSH/12</technical-committee>
    </editorialgroup>
    <ics>
      <code>13.220.20</code>
      <text>Fire protection</text>
    </ics>
    <structuredidentifier>
      <project-number>BS 7273-4:2015 ExComm (Fire)</project-number>
    </structuredidentifier>
  </ext>
</bibdata>

It's supposed to find the standard, not the expert commentary 😉

@ronaldtse
Copy link
Author

@andrew2net this needs to be fixed before Feb 22. Thanks!

@andrew2net
Copy link
Contributor

  • BS EN ISO 13485:2016 ExComm
  • BS 7273-4:2015+A1:2021 ExComm

@ronaldtse BSI has "BS EN ISO 13485 Expert Commentary" and "BS 7273-4:2015+A1:2021 ExComm"
https://knowledge.bsigroup.com/products/expert-commentary-for-bs-en-iso-13485-2016/standard
https://knowledge.bsigroup.com/products/code-of-practice-for-the-operation-of-fire-protection-measures-actuation-of-release-mechanisms-for-doors-2/standard
They can be fetched with relaton fetch 'BS EN ISO 13485 Expert Commentary' and relaton fetch 'BS 7273-4:2015+A1:2021 ExComm' references respectively.
Do you mean we need to fetch all the "Expert Commentary" document usint short "ExComm" in reference?

@andrew2net
Copy link
Contributor

It's supposed to find the standard, not the expert commentary 😉

@ronaldtse BSI only found two standards BS 7273-4:2015+A1:2021 - SET and BS 7273-4:2015+A1:2021, two publications BS 7273-4:2015+A1:2021 ExComm and BS 7273-4:2015 ExComm (Fire), and one article BS 7273-4.
https://knowledge.bsigroup.com/search?page=1&query=BS+7273-4%3A2015&type=all
Which one of these documents should the relaton-bsi fetch with the BS 7273-4:2015 reference?

@ronaldtse
Copy link
Author

This is clearly a problem, that the bibliographic items do not exist. We will report back to BSI.

@ronaldtse
Copy link
Author

In any case, allow us to find the ExComm first?

andrew2net added a commit that referenced this issue Feb 21, 2023
@andrew2net
Copy link
Contributor

@ronaldtse fetching "Expert commentary" documents implemented in v 1.14.4
FYI there is no document "BS EN ISO 13485:2016 ExComm". There is "BS EN ISO 13485 ExComm" without a year.

@ronaldtse
Copy link
Author

@andrew2net this is not good but we will report to BSI. Thanks!

@ronaldtse
Copy link
Author

This is considered done, I will raise to BSI regarding the ExComm without year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants