Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for recent versions of Relay (in relation to Flow types) #128

Open
levibuzolic opened this issue Apr 9, 2021 · 3 comments
Open

Comments

@levibuzolic
Copy link

Currently this package targets quite an old version of relay-runtime (^4.0.0), I'm wondering if there were any existing plans or demand for bringing version up to date (11.x). I've taken a quick look and can see there'd be a few changes required as some of the Flow type signatures have changed since 4.x so I assume there may be some compatibility issues.

I assume this may result in a major breaking version, would there be apetitie for a PR with this upgrade?

@AnotherHermit
Copy link
Collaborator

I would appreciate it at least, I am also currently running Relay v11 and working around some of the current typing issues so it would be nice to get that taken care of.

@nodkz
Copy link
Collaborator

nodkz commented Apr 9, 2021

Sure, PR welcome 👍

I don't use Relay now, so I can't do proper changes myself. It will be very appreciated if somebody who use Relay makes a PR. Tnx.

kodiakhq bot pushed a commit to vercel/next.js that referenced this issue Jun 5, 2021
It appears this library isn't maintained, plus there's already the other `with-relay-modern` example. 

relay-tools/react-relay-network-modern#128
flybayer pushed a commit to blitz-js/next.js that referenced this issue Jun 16, 2021
It appears this library isn't maintained, plus there's already the other `with-relay-modern` example. 

relay-tools/react-relay-network-modern#128
@dr3
Copy link
Collaborator

dr3 commented Mar 6, 2023

@levibuzolic Appreciate its been a very long time since you raised this, but Ive recently picked up maintainance and planning a version 7 of this package. Do let me know if you would like to lend a hand in the relay-runtime upgrade (my flow is rusty 🙈)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants