cache: skip non-kickstart treeinfo [RHELDST-24308] #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out there is a special case in the current CDN config forcing
a fast 404 response on treeinfo URLs not ending in "/kickstart/treeinfo".
A side-effect of forcing that response is that any requests to cache
flush on such a path will fail, e.g.
flush /some/kickstart/treeinfo => OK
flush /some/treeinfo => always fails
As such, we'll need a special case to filter out these paths from any
attempted cache flushes. There is never any need for cache flush if the
response is forced to 404 anyway.
Note this is unlikely to come up in any real publishes of kickstart
repos since those are always using /kickstart in the path.
It came up in the context of migrating some old content to exodus-cdn,
because some files named "treeinfo" exist underneath /origin/files which
will trigger the usual cache flush attempts.
crungehottman
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there is a special case in the current CDN config forcing a fast 404 response on treeinfo URLs not ending in "/kickstart/treeinfo". A side-effect of forcing that response is that any requests to cache flush on such a path will fail, e.g.
As such, we'll need a special case to filter out these paths from any attempted cache flushes. There is never any need for cache flush if the response is forced to 404 anyway.
Note this is unlikely to come up in any real publishes of kickstart repos since those are always using /kickstart in the path. It came up in the context of migrating some old content to exodus-cdn, because some files named "treeinfo" exist underneath /origin/files which will trigger the usual cache flush attempts.