Cookie Requests: Use forwarded cookies, don't generate [RHELDST-18071] #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crungehottman
previously approved these changes
Oct 19, 2023
rohanpm
requested changes
Oct 19, 2023
|
Resolved some comments via release-engineering/exodus-gw#612 |
|
Once this is deployed I will update the config deployed by exodus-cdn-playbooks. |
|
release-engineering/exodus-gw#612 should be merged and deployed before this is submitted. |
rohanpm
previously approved these changes
Oct 22, 2023
rohanpm
requested changes
Oct 23, 2023
|
This will need to be rebased onto #519 |
negillett
force-pushed
the
18071
branch
2 times, most recently
from
9c86443
to
33feeef
Compare
|
Rebased |
rohanpm
requested changes
Oct 26, 2023
Now that exodus-gw provides the necessary cookie data for redirect requests, origin_request can use those rather than generate them itself. This commit makes the necessary changes for that and cleans up now-unused code.
negillett
force-pushed
the
18071
branch
2 times, most recently
from
f9c41e6
to
ecaf7e7
Compare
rohanpm
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that exodus-gw provides the necessary cookie data for redirect requests, origin_request can use those rather than generate them itself.
This commit makes the necessary changes for that and cleans up now-unused code.