Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase request querystring limit 3000 -> 4000 [RHELDST-18071] #519

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Increase request querystring limit 3000 -> 4000 [RHELDST-18071] #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exodus_lambda/functions/origin_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ def validate_request(self, request):
if not 0 < len(request["uri"]) < 2000:
self.logger.error("uri exceeds length limits: %s", request["uri"])
valid = False
if "querystring" in request and not len(request["querystring"]) < 3000:
if "querystring" in request and not len(request["querystring"]) < 4000:
self.logger.error(
"querystring exceeds length limits: %s", request["querystring"]
)
Expand Down
4 changes: 2 additions & 2 deletions tests/functions/test_origin_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def test_origin_request_fail_querystring_validation(caplog):
# Validation fails for too lengthy URIs.
event = {
"Records": [
{"cf": {"request": {"uri": "/", "querystring": "o" * 3001}}}
{"cf": {"request": {"uri": "/", "querystring": "o" * 4001}}}
]
}

Expand All @@ -289,7 +289,7 @@ def test_origin_request_fail_querystring_validation(caplog):
"level": "ERROR",
"time": mock.ANY,
"aws-request-id": None,
"message": "querystring exceeds length limits: %s" % ("o" * 3001),
"message": "querystring exceeds length limits: %s" % ("o" * 4001),
"logger": "origin-request",
"request": None,
"response": None,
Expand Down