Enable usage of this plugin by release-it's require based system
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the move to `type: modules` in package.json this package no longer works within `release-it`'s normal plugin resolution / resolving steps (because it is internally using `import-from` which is basically just doing `require` relative to the current working directory; and you can't `require` a ES modules based file). This adds a very simple wrapper script and leverages the pre-existing static async method `isEnabled` on the plugin instance to absorb async from a dynamic `import()` expression. The `PluginClass.isEnabled()` hook is always called before `new PluginClass` is called, so this system of absorbing the async in `isEnabled` then returning an instance of "the real plugin" from the fake plugin's constructor is pretty safe.
rwjblue
force-pushed
the
add-cjs-wrapper
branch
from
4dcebbe
to
5d8def5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the move to
type: modulesin package.json this package no longerworks within
release-it's normal plugin resolution / resolving steps(because it is internally using
import-fromwhich is basically justdoing
requirerelative to the current working directory; and you can'trequirea ES modules based file).This adds a very simple wrapper script and leverages the pre-existing
static async method
isEnabledon the plugin instance to absorb asyncfrom a dynamic
import()expression. ThePluginClass.isEnabled()hookis always called before
new PluginClassis called, so this system ofabsorbing the async in
isEnabledthen returning an instance of "thereal plugin" from the fake plugin's constructor is pretty safe.