Add support for entering tax as a percentage of Total #4
Conversation
|
Sorry I missed this when you opened it! Will review tomorrow. Thanks for the contribution @arimbun |
|
@relistan No problem, did you have a chance to review it? |
| @@ -33,6 +33,10 @@ billables: | |||
| unit_price: 10.23 | |||
| currency: € | |||
|
|
|||
| # You may enter tax as a percentage here (from 0 to 1.0). | |||
| tax: | |||
| percentage: 0.1 | |||
There was a problem hiding this comment.
We really need to support a default tax and an overridable tax rate per item. Some items may be taxable at different rates.
| @@ -33,6 +33,10 @@ billables: | |||
| unit_price: 10.23 | |||
| currency: € | |||
|
|
|||
| # You may enter tax as a percentage here (from 0 to 1.0). | |||
| tax: | |||
There was a problem hiding this comment.
| tax: | |
| default_tax: |
There was a problem hiding this comment.
You'll need to make various adjustments elsewhere in the code to make this work also. Didn't try to find them all.
| @@ -65,6 +65,10 @@ func (b *BillableItem) Strings() []string { | |||
| } | |||
| } | |||
|
|
|||
| type TaxDetails struct { | |||
There was a problem hiding this comment.
We should call this something like DefaultTax instead.
| b.textFormat(widths[len(widths)-2], 4, "Tax", "1", 0, "R", true, 0, "") | ||
| b.textFormat(widths[len(widths)-1], 4, "0", "1", 0, "R", true, 0, "") | ||
| taxText := billables[0].Currency + " " + niceFloatStr(tax) | ||
| b.textFormat(widths[len(widths)-2], 4, "GST", "1", 0, "R", true, 0, "") |
There was a problem hiding this comment.
| b.textFormat(widths[len(widths)-2], 4, "GST", "1", 0, "R", true, 0, "") | |
| b.textFormat(widths[len(widths)-2], 4, "Tax", "1", 0, "R", true, 0, "") |
GST is a region-specific tax for certain countries. Let's stay with generic "Tax"
There was a problem hiding this comment.
Alternatively, make this configurable in the default_tax block in the config.
There was a problem hiding this comment.
@arimbun MANY apologies for taking so darn long to get to this. It's a side project and finding time can be a challenge. This looks pretty good. I would like to eventually allow item-specific tax calculation, so I've pointed out where I'd like to change what you've got here. Otherwise, good to go. Thank you for the contribution! Again, sorry about how long it took to get to it. @rolandtritsch 's PR was waiting on me for quite awhile as well.
|
Hey @arimbun I've got a little time to deal with this today so I'm going to merge it as-is and do a little work on it now. Thanks again for the contribution! |
Simple support to configure tax as a percentage of Total in the
billing.yamlfile.