Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing a log level to empire #929

Closed
mwildehahn opened this issue Jul 14, 2016 · 1 comment
Closed

Support providing a log level to empire #929

mwildehahn opened this issue Jul 14, 2016 · 1 comment

Comments

@mwildehahn
Copy link
Contributor

This would let us add more debug logging via logger.Debug(ctx, ...) and only enable these during dev or debugging.

mwildehahn added a commit to mwildehahn/empire that referenced this issue Jul 14, 2016
@ejholmes
Copy link
Contributor

ejholmes commented Jul 14, 2016

Somewhat related, I'd love to do a revamp of logging. There's some places where we use the go logger (e.g. cmd/empire) and some places where we use pkg/logger. It'd also probably be good to remove the dependency on pkg/logger and bring it in as remind101/empire/logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants