Simplify initialization of Empire core #692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #688
Closes #606
Fixes #624
Fixes #525
This moves all of the configuration into cmd/empire.
empire.New
goes from 116 lines to just 20 lines and this makes it really simple to use a different scheduler implementation, since it's now just:This also makes it almost impossible to improperly configure empire when starting up, because it won't use fake implementations of interfaces. Everything is much more explicit now.
ECS configuration is now also logged from cmd/empire on start, making it easier to debug configuration issues: