Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Application Load Balancers #969

Merged
merged 3 commits into from
Aug 11, 2016
Merged

Switch to Application Load Balancers #969

merged 3 commits into from
Aug 11, 2016

Conversation

ejholmes
Copy link
Contributor

@ejholmes ejholmes commented Aug 11, 2016

Closes #968

This is mostly a POC at this point, since I haven't done any work to support both classic ELB's and new ALB's so that you can easily swap between both in case there are issues.

But, this does seem to work. The advantage of using ALB's is primarily that we no longer need to allocate and manage instance ports, which means multiple "web" procs can run on the same EC2 instance.

The first commit just updates the aws-sdk-go dependency, and the second includes the actual changes that switch to ALB's.

@phobologic
Copy link
Contributor

Looks good - really should have the ability to switch between old ELB and new ALB at least, just in case there are unforeseen issues with the new system.

@ejholmes
Copy link
Contributor Author

Alright. By default, classic ELB's will be used, but you can now (experimentally) switch to the new application load balancers by setting LOAD_BALANCER_TYPE=alb on the app.

Updated the changelog as well.

@phobologic
Copy link
Contributor

Awesome. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants