Remove pkg/httpx dependency #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
force-pushed
the
go1.7
branch
2 times, most recently
from
811399a
to
99f60eb
Compare
mwildehahn
approved these changes
Sep 15, 2016
| } | ||
|
|
||
| return nil | ||
| // ServeHTTPContext implements the http.Handler interface. |
There was a problem hiding this comment.
nit: comment doesn't match
|
Gonna close this one for now. I'll move this over incrementally later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests may fail right now, which is because of an unrelated change and fixed in #972
Depends on #971
This removes the pkg/httpx dependency, and moves all internal packages to use
contextfrom the stdlib, rather than fromgolang.org/x/net/context, and updates all http handlers to implementhttp.Handlerrather thanhttpx.Handler.First commit is just changes to
./vendor(removepkg/httpxand updategorilla/muxto support Go 1.7 context).Second commit is the actual changes.