respect different FE emission factors in pm_IndstCO2Captured calculation #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschreyer
reviewed
Jul 13, 2023
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
force-pushed
the
fix/industry_CCS_shares
branch
2 times, most recently
from
81edc77
to
45061de
Compare
fschreyer
approved these changes
Aug 18, 2023
| *** NOTE: not used for pm_IndstCO2Captured anymore since it did not take into | ||
| *** account the different emission factors of FE carriers. But used in remind2, | ||
| *** so kept for backwards compatibility. | ||
| o37_demFeIndSub_SecCC(ttot,regi,secInd37) |
There was a problem hiding this comment.
I don't find any occurence of o37_demFeIndSub_SecCC in the remind2 library.
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
force-pushed
the
fix/industry_CCS_shares
branch
from
45061de
to
0af33ac
Compare
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
merged commit 733070d
into
remindmodel:develop
1 check passed
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
added a commit
to 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q/remind
that referenced
this pull request
Aug 18, 2023
…ove unused parameters
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
added a commit
that referenced
this pull request
Aug 21, 2023
…move_unused_industry_output addendum to #1354: carry changes over to fixed_shares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1353
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)Further information (optional):
/p/tmp/pehl/Remind/(running)newandoldshould have different weights but identical totals for CCS in industry subsectors, save for gdx effects due topm_IndstCO2Capturedfeeding back into the solver.