Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t/ttot bug in 46/NDC, correct scenario self-reference in NGFS config #1359

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • Parameter definitions must use ttot, not t. Error introduced by myself :/
  • With use of NPi and change of order, h_cpol used h_cpol as path_gdx_ref which fails. Fixed that temporarily, will update NGFS config anyway in the future.

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • Automated modeltests would ignore these files anyway. Therefore: ./start.R -t config/scenario_config_NGFS_v4.csv startgroup=* works, as does compiling a scenario using the 46/NDC module

@LaviniaBaumstark LaviniaBaumstark merged commit a4b6f14 into remindmodel:develop Jul 13, 2023
1 check passed
@orichters orichters deleted the SSANDC branch December 6, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants