+ script checking if fixing to ref run worked, allows to fix that in post-processing #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orichters
requested review from
LaviniaBaumstark and
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
6 tasks
LaviniaBaumstark
approved these changes
Oct 12, 2023
| @@ -110,7 +110,7 @@ cfg$logoption <- 2 | |||
|
|
|||
| # Just list the name of the output scripts that should be used by output.R | |||
| # At the moment there are several R-scripts located in scripts/output/ | |||
| cfg$output <- c("reporting","reportCEScalib","rds_report") #,"validation","emulator","reportCEScalib","validationSummary","dashboard") | |||
| cfg$output <- c("reporting","reportCEScalib","rds_report","fixOnRef") #,"validation","emulator","reportCEScalib","validationSummary","dashboard") | |||
There was a problem hiding this comment.
yes, let's run it always to besure that everything is working later and for gettign teh info now for the fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
input_ref.gdxcame from, finds the mif file and starts comparingoutput.R), you can even fix that, and the data are then copied over from the old mif. That should be nothing we usually do, but as long as the fixing is incomplete, it allows to submit datasets that are consistent.Type of change
Checklist:
FAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyThis is how the output looks like:
log_fixOnRef.csvis a csv file that certainly could be improved, now its first lines look like that: