Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete realization 36_buildings/services_putty and 36_buildings/services_with_capital #1509

Merged

Conversation

LaviniaBaumstark
Copy link
Member

@LaviniaBaumstark LaviniaBaumstark commented Dec 18, 2023

Purpose of this PR

cleaning up REMiND:
delete old realizations 36_buildings/services_putty and 36_buildings/services_with_capital and all releated code in 29_CESparameters/calibrate

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here: /p/tmp/lavinia/MO/test_cleaningRealizations/remind/output, including calibration
  • Comparison of results (what changes by this PR?):

@LaviniaBaumstark LaviniaBaumstark marked this pull request as ready for review February 2, 2024 07:29
LaviniaBaumstark added a commit to LaviniaBaumstark/remind2 that referenced this pull request Feb 2, 2024
fbenke-pik added a commit to pik-piam/remind2 that referenced this pull request Feb 2, 2024
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
modules/29_CES_parameters/calibrate/preloop.gms Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaviniaBaumstark
Copy link
Member Author

https://github.com/remindmodel/remind/pull/1509/files#diff-54a5960804a16adc77b7ddc96e32be89e442abbd1f89b0fa5cd8e7c5a1b174b7R714

Probably some years-old merge leftover, but that comment should go, too.

I added teh comment, what do you mean?

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

!! complements are not treated in the first iteration

@LaviniaBaumstark LaviniaBaumstark merged commit 266b4d6 into remindmodel:develop Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants